Restoring donation sites to being active. Mea culpa. #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
approved these changes
Apr 3, 2024
| def up | ||
| DonationSite.all.each do |site| | ||
| site.update!(active: true) | ||
| end |
There was a problem hiding this comment.
This works no problem. FYI in the future - it's a lot faster to use update_all.
|
@cielf: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Argh! The last release made all the donation sites inactive (Mea culpa.)
This sets them to all being active.
There is no problem with doing this with a broad stroke, because they were all active before the release. I'm reasonably confident that there aren't any new ones that would have been made inactive. If there are, we'll have to deal with any fallout from that. (there is no creation date on donation sites)
Type of change
How Has This Been Tested?
I deactivated all the donation sites on my local before coding and running this migration. They are now active.
Also ran the test suite on local - all passed