feat: add FMV column to purchases

[sean-dickinson]

Resolves #4314

Description

• Adds the FMV Column to the purchases index page
• Updates the purchases index controller action to eager load the item of each line_item to avoid n+1 issues.
  • Note I also added vendor here to the includes clause as well as I noticed the n+1 in the logs. This is an unrelated change so if you'd like me to revert that I'd be happy to.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

• Added a new spec to the purchases system spec
• Tested manually by viewing the page (with seeded data)

Screenshots

Before

After

[dorner]

Overall looks good, but had one request.

[dorner]

Can this be a request spec instead of a system spec? It's a lighter load.

[sean-dickinson]

Sure thing. I was following the pattern of the test above. Do you want me to move that one too? Or maybe just add a to-do comment to keep this PR scoped to this change?

[dorner]

Looks good! @cielf did you want to take a look?

[cielf]

I think we can put this forward, and that there should be a couple of follow-on things that I'll write up and get into our backlog --
1/ our header alignments could use some work, which will make a series of Good First Issues, and
2/ FMV is a total-able column, so we should give the totals as well. @sean-dickinson: If you're interested in working on putting the totals in, let me know, and I'll prioritize getting the issue groomed.

[sean-dickinson]

I think we can put this forward, and that there should be a couple of follow-on things that I'll write up and get into our backlog -- 1/ our header alignments could use some work, which will make a series of Good First Issues, and 2/ FMV is a total-able column, so we should give the totals as well. @sean-dickinson: If you're interested in working on putting the totals in, let me know, and I'll prioritize getting the issue groomed.

I'd be happy to add the totals

[github-actions]

@sean-dickinson: Your PR feat: add FMV column to purchases is part of today's Human Essentials production release: 2024.05.12.
Thank you very much for your contribution!