Fix #4447 Fix #3987 Fix #3755 merge README into CONTRIBUTING and document deploy process

[jimmyli97]

Resolves #4447 Resolves #3987
Together with #3766 resolves #3755

Description

• Removes duplication from README and CONTRIBUTING by merging all contribution guidelines from README into CONTRIBUTING
• Clarifies to run bundle exec rake and bin/lint before pull requests
• Fix dead links in sbv.md
• Document date-based versioning deploy process

Additional changes:

• Fix slack link in CONTRIBUTING
• Write contribution guidelines in more of a table-of-contents style with a general overall workflow checklist which links to more details
• Added a note about using binding.pry in rspec for specific line numbers
• Added a note about what automated tests run on pull request
• Use git push origin tag <tagname> instead of git push --tags, see this SO post for why

Motivation

Basically what I mentioned in #4447, the duplication of guidelines is a bit confusing as well as the conflicting information about what to run before making a pull request. Also, I wanted a checklist that I could glance at to make sure I did everything correctly.

Type of change

• Documentation update

How Has This Been Tested?

Opened README and CONTRIBUTING and SBV in browser

[dorner]

I'm OK with this, other than one comment. @awwaiid did you want to take a look?

[dorner]

This isn't part of the contribution guidelines, no?

[jimmyli97]

It's in the README at the bottom in the master repository and issue #3987 said to document the deploy process, so I figured I would put it in CONTRIBUTING. Should I put it back in the README? Or delete it?

[dorner]

Let's put it back in the README.

[jimmyli97]

resolved by 9cb04c1

[dorner]

Thanks!

[github-actions]

@jimmyli97: Your PR Fix #4447 Fix #3987 Fix #3755 merge README into CONTRIBUTING and document deploy process is part of today's Human Essentials production release: 2024.06.23.
Thank you very much for your contribution!