Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4437 preserve kit form fields upon error #4452

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Jun 14, 2024

Resolves #4437

Description

Updates KitsController#create to so that submitted form field data is re-populated in page re-render upon creation error

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

sign in as org_admin1@example.com
Inventory | Kits
click "New Kit"
without specifying a name, specify an item in the kit ("Choose an Item" and fill in Quantity)
Click Save

You will get an error but the item and quantity you have specified will be present in their respective fields. (as per issue repro steps)

Also added feature test to existing system specs concerning kit creation

@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review June 14, 2024 21:31
@PhilipDeFraties PhilipDeFraties force-pushed the 4437-preserve-kit-form-fields-upon-error branch from 56d6abc to f32b667 Compare June 14, 2024 21:36
@PhilipDeFraties PhilipDeFraties self-assigned this Jun 14, 2024
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes manual testing. Over to @dorner for technical ok.

@cielf cielf requested a review from dorner June 16, 2024 12:32
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dorner dorner merged commit 5550705 into main Jun 16, 2024
38 checks passed
@dorner dorner deleted the 4437-preserve-kit-form-fields-upon-error branch June 16, 2024 19:39
Copy link
Contributor

@PhilipDeFraties: Your PR 4437 preserve kit form fields upon error is part of today's Human Essentials production release: 2024.06.23.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] if you have an error in defining a kit, the information you entered is not preserved. It should be.
3 participants