-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4409] Only show fulfillment column if partner has default location #4466
Changes from 3 commits
e12d37d
bd936b8
c2fc041
90098cd
9e77b48
fae5b26
a5c908e
5e5aa72
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,6 +48,34 @@ | |
expect(response).to have_http_status(:not_found) | ||
end | ||
end | ||
|
||
context 'When organization has a default storage location' do | ||
let(:request) { create(:request, organization: create(:organization, default_storage_location: 1)) } | ||
it 'shows the column Default storage location inventory' do | ||
get request_path(request) | ||
|
||
expect(response.body).to include('Default storage location inventory') | ||
end | ||
end | ||
|
||
context 'When partner has a default storage location' do | ||
let(:storage_location) { create(:storage_location) } | ||
let(:request) { create(:request, partner: create(:partner, default_storage_location_id: storage_location.id)) } | ||
it 'shows the column Default storage location inventory' do | ||
get request_path(request) | ||
|
||
expect(response.body).to include('Default storage location inventory') | ||
end | ||
end | ||
|
||
context 'When partner or organization does not have a default storage location' do | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a nitpick, but this should be 'When neither partner nor organization has a default storage location' -- i.e. that it has to be both the partner doesn't and the organization doesn't. Your description means, instead, if the partner doesn't have it or the organization doesn't have it, which is not quite the same thing. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed it here 90098cd |
||
let(:request) { create(:request, organization: organization) } | ||
it 'does not show the column Default storage location inventory' do | ||
get request_path(request) | ||
|
||
expect(response.body).not_to include('Default storage location inventory') | ||
end | ||
end | ||
end | ||
|
||
describe 'POST #start' do | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one more thing on my last go-through -- and this is extremely nitpicky.
I think it would be better if we switched the two clauses in this or?
Why? You are only using the existence of a default storage location, but, If someone later decides to use the default storage location (say we decide to change the title) - it should match what we are using for getting the on_hand_for_location. In the probably rare case where the organization and partner both have default locations, we use the partner location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I fixed it here 9e77b48