[4458] - Restrict non admins to partner users #4468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Jun 21, 2024
| @@ -31,6 +42,8 @@ | |||
|
|
|||
| context "with valid user params" do | |||
| it "invites a new user and redirects back with notice" do | |||
| user.add_role(:org_admin) | |||
There was a problem hiding this comment.
Can you move this to a before(:each) block?
There was a problem hiding this comment.
Fixed it here 129a2b8
|
|
||
| context "when user is not authorized" do | ||
| it "does not have access to index template" do | ||
| user.add_role(:org_user) |
There was a problem hiding this comment.
This gets added automatically, you don't need to do it.
There was a problem hiding this comment.
Fixed it here 129a2b8
dorner
requested changes
Jun 26, 2024
| @@ -72,6 +73,8 @@ | |||
| end | |||
|
|
|||
| it "redirects back with alert if the user role removal fails" do | |||
| user.add_role(:org_admin) | |||
There was a problem hiding this comment.
This line shouldn't be necessary since it's in a beforeblock, no?
There was a problem hiding this comment.
Right. I think I missed this one. Fixed it here f0ab010
|
Looks like there are failing tests now. |
|
@napster235 will you be able to fix the tests? |
|
not any time soon i'm afraid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4458
Description
Type of change
How Has This Been Tested?
Specs were added
Screenshots