Show inventory history for pre-event read #4469
Conversation
|
Hey @awwaiid I'll be reviewing this functionally tomorrow (hopefully pre-meeting). I fully expect it to work. Could you do a technical review in parallel? |
|
Looks like it works, ish-- the totals are wrong, and they are wrong for everyone on the production branch as well - i suspect it's just showing the current total inventory and that it has always been wrong but haven't looked into it. That is out of scope for this issue, I guess, but I would not be at all averse to including a fix for that in. (but am adding a proto issue) |
|
Fixed for the events_read cases (both within event time and before it). |
|
LGTM. Waiting for @awwaiid's review. |
|
@dorner: Your PR |
Fix for #4433 .
This will show inventory history regardless of whether the time selected had events active or not. If the time is before events were active, it will use inventory item versions (using paper_trail).