#4398: Support units in requests #4510
Conversation
|
If anyone wants to grab this and finish writing the specs before I can get to it, feel free :) |
# Conflicts: # db/migrate/20240704214509_backfill_partner_child_requested_items.rb
dorner
changed the title
|
@cielf pushed the fix! |
|
The test that is failing has packs in its description, so might be a real failure? |
|
Should be fixed now! |
|
LGTM @awwaiid could you take a look? |
| # hash of (item ID => hash of (request unit name => request unit plural name)) | ||
| @item_units = current_partner.organization.items.to_h do |i| | ||
| [i.id, i.request_units.to_h { |u| [u.name, u.name.pluralize] }] | ||
| end |
There was a problem hiding this comment.
Since this is identical to the one in create please extract it into a private method.
| <td> | ||
| <%= field.label :item_id, "Item Requested", {class: 'sr-only'} %> | ||
| <%= field.select :item_id, @requestable_items, {include_blank: 'Select an item'}, {class: 'form-control'} %> | ||
| <%= field.select :item_id, @requestable_items, {include_blank: 'Select an item'}, |
There was a problem hiding this comment.
So here we already only show the @requestable_items in the item select drop-down, so that already narrows down what we might show in the units drop down. So the generated @item_units having all possible items it works fine, but could be narrowed down to building off of @requestable_items
|
Further thoughts on the default -- if we have multiple custom units the first one may or may not be the most used. I'm wondering if we should default at all. (Or we may yet need to add a default unit indicator). We'll figure this out after talking to the business on Wednesday. |
@dorner We talked to the business Wednesday, and they said they'd rather have the units not initially selected, but that, of course, they have to select something. This is because a single bank will have partners who do packs and partners that don't and they want to avoid a default that would be a mistake. |
|
@dorner I keep trying combinations of re-running these failing tests and trying to get it to fail locally and so far no luck :( |
|
Ah, I got it to fail and then fixed it! |
|
@dorner: Your PR |
Resolves #4398
Description
This shows a Units field if the partner's organization has any custom request units.
If the selected item has any request units, the Unit drop-down is shown and the first custom request unit is selected. Otherwise, the drop-down is not shown.
If the enable_packs flag is off, no behavior change is shown.
Type of change
How Has This Been Tested?
Local testing. Still needs specs created.
Screenshots