Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/improve children export fields #4530

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented Jul 14, 2024

Resolves #4525

Totally forgot about this PR. Adds additional fields for the child requests to the export. The requested items will be comma separated.

@elasticspoon elasticspoon force-pushed the feat/improve-children-export-fields branch from 7cf0a8c to 6dff365 Compare August 3, 2024 23:16
@elasticspoon elasticspoon marked this pull request as ready for review August 3, 2024 23:31
@elasticspoon elasticspoon requested review from dorner and cielf August 3, 2024 23:31
Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, fits the original ticket. Uses separate first-name and last-name fields, but I think that's fine.

@awwaiid awwaiid merged commit d303832 into main Aug 4, 2024
38 checks passed
@awwaiid awwaiid deleted the feat/improve-children-export-fields branch August 4, 2024 19:51
Copy link
Contributor

@elasticspoon: Your PR Feat/improve children export fields is part of today's Human Essentials production release: 2024.08.11.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to partner's export children
2 participants