Partner request units display (packs-4) #4399 #4531
Conversation
And also fix traits, which seem like they shouldn't have worked this way. [#4399]
|
|
||
| trait :fulfilled do |
There was a problem hiding this comment.
I'm not sure these ever worked since they weren't nested inside of the factory block.
There was a problem hiding this comment.
If they didn't work, can we just delete them?
There was a problem hiding this comment.
Sorry they WORK but they were being defined globally instead of scoped to only the Requests factory. So any other factory could have been using these traits on accident, though lucky us nothing else is using them. I verified that all of them ARE being used.
There are unfortunately existing specs which don't pass in valid data for building out the item_requests, so here we make it an explicit trait that must be requested. [#4399]
|
Here is a screenshot. It does pluralization and such. |
| trait :with_item_requests do | ||
| after(:build) do |request| |
There was a problem hiding this comment.
I ended up making this an explicit trait so that it doesn't interfere with existing specs that don't pass in valid data.
awwaiid
changed the title
|
It is, alas, a tad hard to properly test this one out until packs-3 is also in place. |
|
|
||
| trait :fulfilled do |
There was a problem hiding this comment.
If they didn't work, can we just delete them?
|
@cielf any issue merging this? It seems really safe since the only behavior change is locked behind the feature flag. |
|
@awwaiid: Your PR |
Implements #4399, aka Packs-4.
Validated through interactive testing locally with mock data, along with unit tests.