Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USER_GUIDE]: Add Vendors user guide #4581

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

wanguiwaweru
Copy link
Contributor

Description

Type of change

  • Documentation update

How Has This Been Tested?

Screenshots

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wanguiwaweru -- Thanks for this! I think I'm getting pickier on the first pass as I write my own sections.

A lot of what I suggest here is about making things more concise, with a bit of adding variety in language. ( It's hard to get a balance between using the terms that are in the system and not wanting to make the user tired of reading the same word over and over.)

I also added a bit of additional 'expert' advice for the users.

docs/user_guide/bank/community_vendors.md Show resolved Hide resolved
docs/user_guide/bank/community_vendors.md Outdated Show resolved Hide resolved
docs/user_guide/bank/community_vendors.md Show resolved Hide resolved
docs/user_guide/bank/community_vendors.md Show resolved Hide resolved
docs/user_guide/bank/community_vendors.md Show resolved Hide resolved
docs/user_guide/bank/community_vendors.md Show resolved Hide resolved
docs/user_guide/bank/community_vendors.md Show resolved Hide resolved
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very close -- i missed one thing in my initial pass -- can you put a screen shot explicitly pointing at the "+New Vendor" button, please?

Then this should be good to go.

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cielf cielf merged commit 2a24224 into rubyforgood:main Aug 7, 2024
20 checks passed
Copy link
Contributor

@wanguiwaweru: Your PR [USER_GUIDE]: Add Vendors user guide is part of today's Human Essentials production release: 2024.08.11.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants