Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4578: Better wording on request sent page #4583

Conversation

prasath1196
Copy link

Resolves #4578

Description

Text changes on the page that is shown after the partner submits a request.

[ Organization name] should have received the request.
to
We've sent [Organization name] your request.

Change
You should also be receiving a email confirmation in a few minutes.
to
We will send you an email confirmation in a few minutes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The change is tested manually.

To see this page, sign in as verifed@example.com, then click on Quantity, fill a couple of items and quantities, click submit (and if a confirmation page appears, click "It's correct'. A page like the following will appear.

Screenshots

Screenshot 2024-08-06 at 2 32 40 PM

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @prasath1196 -- thank you! The change looks good to me.

In future, can you match the title of the PR to the issue, please? That helps when we are doing the release documentation. It doesn't have to match exactly, but should give the idea (I'm going to go ahead and change it myself now)

@cielf cielf changed the title 4578: Removed gemfile changes 4578: Better wording on request sent page Aug 7, 2024
@cielf cielf merged commit 6c3bde0 into rubyforgood:main Aug 7, 2024
19 checks passed
@prasath1196
Copy link
Author

@cielf Thanks! I will keep that in mind next time

Copy link
Contributor

@prasath1196: Your PR 4578: Better wording on request sent page is part of today's Human Essentials production release: 2024.08.11.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better wording on partner request sent page
3 participants