#4403: Show units in new/edit distribution

[dorner]

This makes a number of changes related to showing requested items and packs on the distribution pages.

• Editing distributions will silently remove any items that have a quantity of 0. Before this threw an error. All other itemizables and new distributions should remain the same.
• Distribution New / Edit pages now show all items requested (regardless of whether there is a current line item in the distribution with that requested item). All requested items are disabled on the distribution page and cannot be changed. (Quantity can be changed to 0 though.)
• Request units are now shown on the distribution page if relevant.

See the original issue (#4403) for more details.

[cielf]

It looks pretty good to me. I'm not 100% convinced that the larger font on the requested column is the way to go. It feels a little strange but I can see it drawing attention to the packs aspect when there.

For further discussion -- should we have the barcodes in place in this situation -- do they serve any purpose?

[dorner]

Good question. I think it makes sense to remove them.

[dorner]

Fixed!

[cielf]

I like it -- it's going to be much more compact. I do want to show it to the stakeholder circle pre-release in case there is a reason we need to have them ( though, if we do, we're going to have to do some fancy error handling on the barcodes)

@awwaiid Over to you for technical review, please!

[awwaiid]

If you save the distribution without selecting the storage location you get an error, as expected. Not as expected is that this then flips all of the requested lines to be the barcode style and loses the units.

Before save:

After save:

[dorner]

Should be fixed now!

[awwaiid]

Great! Holding off on merge until after the release tomorrow.

[github-actions]

@dorner: Your PR #4403: Show units in new/edit distribution is part of today's Human Essentials production release: 2024.09.01.
Thank you very much for your contribution!