Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distributions labels #4597

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

norrismei
Copy link
Contributor

@norrismei norrismei commented Aug 16, 2024

Description

I was on the Distributions page and noticed a typo in a column name. Since I was submitting an edit, I did a light proofread of the page and decided to make a few more changes:

  • [Update: this change is being pulled out of this PR. See comment below.] Changed the column "State" to read "Status." I believe Status is what was intended + more widely used/better understood in this context + the filter is labeled "Filter by Status"
  • Made capitalization consistent throughout filter labels and column names to make page look spiffier

Type of change

Non-breaking edits

Screenshots

Before:
Before changes

After:
After changes

@dorner dorner requested a review from cielf August 16, 2024 19:25
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @norrismei -- Good eye! I agree with the thought behind the change, but want to split off the state->status because it should have a wider scope.

app/views/distributions/index.html.erb Outdated Show resolved Hide resolved
@norrismei norrismei requested a review from cielf August 19, 2024 04:50
@cielf cielf merged commit 88281d6 into rubyforgood:main Aug 21, 2024
19 checks passed
Copy link
Contributor

@norrismei: Your PR Fix distributions labels is part of today's Human Essentials production release: 2024.08.25.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants