Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling old/stale account requests #4621

Conversation

manuel1280
Copy link
Contributor

Checklist:

  • I have performed a self-review of my own code,
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes ("bundle exec rake"),
  • Title include "WIP" if work is in progress.

Resolves #1 4514

Description

This new button allows admin users to close old and stale Account requests without sending emails or notifications. this new feature is relevant to clean up data easily. my approach for the solution was:

  • reuse the existing button 'Reject' and its modal by a dynamic code in javascript
  • unnecessary code was removed and reactors were made
  • following the current pattern of no-rest actions, the 'close' action was created
  • create test files

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

running these files

  • account_request_spec.rb
  • account_requests_controller_spec.rb
  • manually testing

Screenshots

@manuel1280 manuel1280 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant