4515 - Deactivated partners should not appear in the dropdown when producing a new distribution. #4639
Conversation
This commit adds in a conditional check to the _form partial that checks where the partial is coming from. If it is being rendered from the 'new' view, it will then generate a partner list that filters out the deactivated partners. If it is being rendered from anywhere else, it will generate the complete partner list unfiltered. [Ticket: 4515]
| @@ -1,3 +1,11 @@ | |||
| <% | |||
| partner_list = if defined?(source) && source == 'new' | |||
There was a problem hiding this comment.
This actually shouldn't be calculated by the view at all. It's better to pass this in from whatever view is calling the partial.
Very simple DB queries are kind of OK within views, but in general we should be aiming not to have views talk to the DB at all.
There was a problem hiding this comment.
that makes sense. I'll move the query into the controller actions and pass them from there.
| create(:partner, name: 'Deactivated Partner', organization: organization, status: "deactivated") | ||
| end | ||
|
|
||
| it "should not display deactivated partners on new distribution" do |
There was a problem hiding this comment.
This one can be a request spec. It's faster than a system spec.
|
I've made those updates! |
|
Looks good now! |
|
@ewoknock: Your PR |
…oducing a new distribution. (rubyforgood#4639) * Filters out deactive partners on new distribution This commit adds in a conditional check to the _form partial that checks where the partial is coming from. If it is being rendered from the 'new' view, it will then generate a partner list that filters out the deactivated partners. If it is being rendered from anywhere else, it will generate the complete partner list unfiltered. [Ticket: 4515] * Updates the re-render of create on a fail to also filter out the deactivated partners * Adds in unit tests for distribution dropdown * Removed unneeded variable declaration for unit tests * Moves the partner_list query from the view into the controller actions * Moved rspec tests from 'system' to 'requests'
Resolves #4515
Description
When creating new distributions, the "Partner" dropdown should not contain deactivated partners.
However, when editing an existing distribution, you should still see deactivated partners.
This change is to reduce the number of errors and make it easier for the banks to create distributions.
To implement this feature, I added in a conditional check on the distribution form partial. If the "source" local variable has been passed to the partial and contains the value "new", then the deactivated partners will be filtered out of the partner list.
In any other case, the form partial will just render the full partner list associated with the bank.
This allows the bank to still edit distributions for partners that may have been deactivated since the distribution was created.
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
I first tested this manually by deactivated one of the partners.
I created a new distribution and confirmed that the partner was no longer in the dropdown.
I tried to make a new distribution but intentionally added in errors and confirmed that it would still properly filter out deactivated partners on a re-render.
I tried to edit some existing distributions and confirmed that the deactivated partners still showed up on the list.
I also created unit tests that are located in spec/system/distribution_system_spec.rb
Screenshots
New distribution after error filters out Pawnee Parent Service
Editing an existing distribution still allows you to select Pawnee Parent Service
