Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USER_GUIDE]: Add donation sites user guide #4660

Merged
merged 6 commits into from
Sep 20, 2024
Merged

USER_GUIDE]: Add donation sites user guide #4660

merged 6 commits into from
Sep 20, 2024

Conversation

wanguiwaweru
Copy link
Contributor

Description

Add donation sites user guide

Type of change

  • Documentation update

cielf
cielf requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks pretty good -- just tweaks and some changes around how deactivate and export work (which aren't obvious)(which is one of the reasons we need a guide!)

docs/user_guide/bank/community_donation_sites.md Outdated Show resolved Hide resolved
docs/user_guide/bank/community_donation_sites.md Outdated Show resolved Hide resolved
docs/user_guide/bank/community_donation_sites.md Outdated Show resolved Hide resolved
docs/user_guide/bank/community_donation_sites.md Outdated Show resolved Hide resolved
cielf
cielf requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@cielf cielf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks great now!

I didn't notice that empty file 2 initially, and we shouldn't need any changes to gemfile.lock... can you address those, please?

@wanguiwaweru
Copy link
Contributor Author

Sorry about that. I must have pushed them by mistake.

@cielf cielf merged commit 8e26163 into rubyforgood:main Sep 20, 2024
12 checks passed
@github-actions GitHub Actions
Copy link
Contributor

@wanguiwaweru: Your PR USER_GUIDE]: Add donation sites user guide is part of today's Human Essentials production release: 2024.09.22.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cielf cielf cielf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanguiwaweru @cielf