Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolves #4633] Improve confirmation text when saving new audit #4721

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tatheerf02
Copy link
Contributor

Resolves #4633

Description

  • This change adds more detail to the confirmation text displayed to a user when submitting a new audit.
  • I opted to just add on to the existing text in the ERB file, instead of creating a new pattern for custom confirmation dialogs.
  • I had to switch the string to double quotes to allow the new lines to be picked up. Is there a different way we would like to format it?

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I did not add any additional tests as this felt like a "styling change" as described here in the contributing guidelines.
Should I be writing a system test for this change regardless?

Screenshots

Before After
Screen Shot 2024-10-14 at 1 27 08 PM Screen Shot 2024-10-14 at 12 21 39 PM

@tatheerf02 tatheerf02 force-pushed the 4633-audit-confirmation-text branch from 6d96387 to f0f888f Compare October 14, 2024 17:33
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@cielf cielf merged commit 64d20c1 into rubyforgood:main Oct 16, 2024
11 checks passed
Copy link
Contributor

@tatheerf02: Your PR [Resolves #4633] Improve confirmation text when saving new audit is part of today's Human Essentials production release: 2024.10.20.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text on confirming audit that the audit must be finalized for it to take effect.
2 participants