Fix scanning new barcode item issue (#4592) #4731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
approved these changes
Oct 27, 2024
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4592
Description
Made a change so that the new barcode item modal triggers a return keypress once saved. Which then looks up the newly created barcode, fills in details, adds new item, and changes focus.
An alternative approach would have been to fix/add that logic to the new barcode modal. The advantage being that we avoid one additional request (to
/barcode_items/find.json?barcode_item[value]=XXXX), because we already know the item name/quantity. But the disadvantage being that we have that javascript logic in two places (create.jsmodal andbarcode_items.jsutility), so that's why I chose the first approach.Type of change
How Has This Been Tested?