Allow Organization and Partner Profile edit when associated records have validation errors #4737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starts with lowercase, no . at end
cielf
reviewed
Oct 29, 2024
There was a problem hiding this comment.
I tried this against production data. At first I thought it wasn't working as expected, but it turns out that you only would get the problem if one of the flags that control the available request types is "No".
It looks fine to me from a functional pov. Still needs a technical review.
|
@jp524: Your PR |
jp524
deleted the
4720-allow-organization-edit-with-partner-validation-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4720
Description
This solves the problem raised in the issue where Organizations could not be edited when an associated Partner Profile had an invalid pick-up email. Instead of rendering a 500 page, an error is shown to the user.
I can confirm that the validity of a Partner doesn't impact updating an Organization, unlike Partner Profile.
While looking at this issue I noticed that a Partner's email was not validated during the update process. It was only validated at creation.
I fixed this validation and also modified the Partner Profile update service to not fail if the Partner email was invalid.
Type of change
How Has This Been Tested?
Added a few tests in the update services.
Screenshots
Updating Partner Profile with invalid Partner
Updating Organization with invalid Partner Profile
