-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #4740 - Add new default date range #4752
Resolves #4740 - Add new default date range #4752
Conversation
I removed the "this_year" method from DateRangeHelper because it is no longer used |
@jorgecoutinhobr We still want This Year to be available -- just not the default. |
@cielf It is still possible to use the "this year" filter, because it is defined in application.js. I removed the "this year" method from DataRangeHelper, because it was only used to set a default date if the params were nil. But if necessary I can return with this method. |
@jorgecoutinhobr Thanks for the clarification! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it out, and it looks good to me!
@dorner - Do you have any concerns?
Nope! |
@jorgecoutinhobr: Your PR |
Resolves #4740
Description
Type of change
How Has This Been Tested?