Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #4740 - Add new default date range #4752

Merged

Conversation

jorgecoutinhobr
Copy link
Contributor

Resolves #4740

Description

  • Change the default date range for all filters to 60 days prior, 30 days in the future.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • add test cases for default range in date_range_picker_shared_example

@jorgecoutinhobr
Copy link
Contributor Author

I removed the "this_year" method from DateRangeHelper because it is no longer used

@cielf
Copy link
Collaborator

cielf commented Oct 31, 2024

I removed the "this_year" method from DateRangeHelper because it is no longer used

@jorgecoutinhobr We still want This Year to be available -- just not the default.

@jorgecoutinhobr
Copy link
Contributor Author

I removed the "this_year" method from DateRangeHelper because it is no longer used

@jorgecoutinhobr We still want This Year to be available -- just not the default.

@cielf It is still possible to use the "this year" filter, because it is defined in application.js. I removed the "this year" method from DataRangeHelper, because it was only used to set a default date if the params were nil. But if necessary I can return with this method.

imagem_2024-10-31_085430334

@cielf
Copy link
Collaborator

cielf commented Oct 31, 2024

@jorgecoutinhobr Thanks for the clarification!

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, and it looks good to me!
@dorner - Do you have any concerns?

@cielf cielf requested a review from dorner November 1, 2024 15:23
@dorner
Copy link
Collaborator

dorner commented Nov 1, 2024

Nope!

@dorner dorner merged commit 4fcf1e6 into rubyforgood:main Nov 1, 2024
11 checks passed
Copy link
Contributor

github-actions bot commented Nov 3, 2024

@jorgecoutinhobr: Your PR Resolves #4740 - Add new default date range is part of today's Human Essentials production release: 2024.11.03.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default date range for all filters to 60 days prior, 30 days in the future.
3 participants