Fix 404 errors showing up as 500 errors

[dorner]

Fixes #4765 .

First off, note that this error can only be reproduced on local if you change

  config.consider_all_requests_local = true

in development.rb to false.

The reason that a redirect to /404 happens is because of this line in application.rb:

    config.exceptions_app = routes

This forwards the error logic to the router, which redirects to a route that matches e.g. /404. When this happens, we lose all information about the route that couldn't be found. We also end up with a very bad-looking 500 error if the user isn't logged in.

I've removed this line so that Rails goes back to the default path of showing the file in public/404.html etc. I copy-pasted the end result of the current logic to show the static page that shows up regardless of whether the user is logged in or not. Sample for 500 below.

[awwaiid]

Let's move forward with this; separately maybe we should look at trimming down the javascript payload on the error pages.

Thanks for the notes, TIL several details from them!

[github-actions]

@dorner: Your PR Fix 404 errors showing up as 500 errors is part of today's Human Essentials production release: 2024.11.13.
Thank you very much for your contribution!