Improve client share error message

[McEileen]

Resolves #4673

Description

This PR modifies the error message that partners will see when they attempt to add another county to "area served" and do not submit a value for the "client share" field. The error message will now be "Something didn't work quite right -- try again? Validation failed: Served areas client share is not a number, Served areas Client share must be between 1 and 100 inclusive".

I do think it looks a little goofy to have Client capitalized in the Served areas Client share must be between 1 and 100 inclusive message. I included that because I wanted to verbatim copy the error message suggested in issue #4673. I would be happy to refactor and change the capitalization.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• I added an automated test to spec/models/partners/served_area_spec.rb
• I updated an automated test in spec/services/partner_profile_update_service_spec.rb to expect the updated message.
• I manually recreated the bug and witnessed the new error message. I will copy below the repro steps from issue Better error message where partner's served areas % client share left blank. #4673

1. sign in as org_admin1@example.com
   

2. Click "Partner Agencies", then "All Partners". Click a Partner, then scroll down and click "Edit information".
   
3. Find the Area Served section
   
4. Click "Add Another County".
   
5. Choose a "County or Equivalent". Do not fill in the client share % field beside it.
   
6. Go to the bottom of the page and click "Update Information".

Screenshots

New inline error message

New error message at top of page

[dorner]

Looks good on my end.

[cielf]

It looks good to me too.

[github-actions]

@McEileen: Your PR Improve client share error message is part of today's Human Essentials production release: 2024.11.24.
Thank you very much for your contribution!