Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4792 Update the email that partners get when they are approved #4795

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

spudoodle
Copy link
Contributor

Resolves #4792

Description

Update the text in the email that partners get when they are approved to You have been approved to make requests for essentials to [bank name].

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I've updated the test spec/mailers/partner_mailer_spec.rb to expect You have been approved to make requests for essentials to [bank name].

Screenshots

image

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me from a functional pov. @dorner -- is there any concern with the additional platform in the gemfile.lock? (I don't think there is, but dotting the i's...)

@cielf cielf requested a review from dorner November 20, 2024 17:38
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues, all good!

@dorner dorner merged commit 8fe4485 into rubyforgood:main Nov 22, 2024
11 checks passed
@spudoodle spudoodle deleted the 4792-update-approved-email-text branch November 22, 2024 05:26
Copy link
Contributor

@slusy: Your PR 4792 Update the email that partners get when they are approved is part of today's Human Essentials production release: 2024.11.24.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the email that partners get when they are approved to be more informative.
3 participants