Adding counties to partner export for NDBN reporting #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Dec 11, 2024
app/models/partners/profile.rb
Outdated
| # provides a county list in case insensitive alpha order, by region, then county name | ||
| counties = served_areas.map(&:county).uniq | ||
| counties.sort_by! { |county| [county.region.downcase, county.name.downcase] } # Our current world only has the US states, so downcasing the region doesn't really matter. | ||
| counties.pluck(:name).join("; ") |
There was a problem hiding this comment.
Can we move this to SQL? You can add has_many :through for counties to the profile, and then you can do something like
self.counties.order(%w(region name)).pluck(:name).join('; ')
There was a problem hiding this comment.
I don't think that will get me the downcase, but I'm sure there's a way to get that in there too.
There was a problem hiding this comment.
Made those changes. Added a second profile to the test to make sure that there isn't crosstalk.
dorner
approved these changes
Dec 13, 2024
|
@cielf: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial #3067
Description
This adds a list of counties served, in case-insensitive order by county name within region, to the partner export
Type of change
How Has This Been Tested?