Remove duplicate donation system spec

[coalest]

Doesn't resolve any issue.

Description

While investigating flaky specs, I noticed what looks like the same spec twice in a row. Look at the spec directly underneath the removed code in this PR (the one titled "Allows User to create a donation with a Miscellaneous source").

I did a diff and the only thing different between them is the spec description in double quotes.

The two specs were commited in 17e818c. I can't figure out what was meant to be tested here so maybe we can just remove it?

Type of change

• Internal

[dorner]

Maybe this spec was meant to test one of the other types, like Product Driver or Manufacturer?

[cielf]

The phrasing is very odd " it "Allows User to create a donation for Purchased Supplies" -- I think the very first iteration of the system only had donations and distributions, which might explain this.

[coalest]

There are already specs in this file for creating donations from all other types of donation sources (product drives, manufacturers, and donation sites).

I don't understand what the wording is trying to say... 🤷

[cielf]

Here's my theory. That commit is from the very very early days of the project. The system started with donations and distributions. Based on my knowledge of the project, I think someone was working on allowing purchases through donations, didn't carry it through, and it got missed in the review. I do think we can get rid of that one.

[github-actions]

@coalest: Your PR Remove duplicate donation system spec is part of today's Human Essentials production release: 2024.12.22.
Thank you very much for your contribution!