Fix flaky partners requests request spec #4870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue. But it is one of the specs mentioned in this flaky specs issue.
Description
In the spec we are expecting the
family_zipcodes_list
to have a certain order but no order is guaranteed in the request. This changes our expectation to match current behavior (order of zip codes doesn't matter).Example backtrace:
(found in this comment)
Type of change
How Has This Been Tested?
I wasn't able to reproduce this failure locally. But changing the order of the zipcodes in the setup didn't break the spec so this should in theory fix the issue.