Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP for Issue #487 #501

Merged
merged 6 commits into from
Oct 17, 2018
Merged

WIP for Issue #487 #501

merged 6 commits into from
Oct 17, 2018

Conversation

jash-kothari
Copy link
Contributor

@jash-kothari jash-kothari commented Oct 9, 2018

Description

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Screenshots

Steps to check

  • Create a new distribution.
  • After distribution has been created mail will be sent to corresponding partner for which distribution has been created with attached pdf.

@jash-kothari jash-kothari self-assigned this Oct 9, 2018
Copy link
Collaborator

@jtu0 jtu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jash-kothari, thanks for tackling this issue!

There are a few changes I'd like to see before this branch gets merged:

  • In the PR description, include step-by-step instructions (including any necessary configuration steps) for how to verify your code changes and confirm behavior is good
  • Add a simple spec that runs through the happy path for how this feature might get used
  • Make sure rubocop is passing (run rubocop -a to see failures and recommendations for how to fix)

I'll be able to give more concrete suggestions for code improvements once those first two are done.

Again, thanks for your hard work on this PR - it's going to make a big difference in the lives of our hard-working diaper banks' staff!

@seanmarcia seanmarcia removed their request for review October 12, 2018 18:21
@seanmarcia
Copy link
Member

Hey @jash-kothari I really like how you started this PR! Is there any help you need or anything we can do to help you get this across the finish line? Please let us know if the changes that were requested don't make sense or you need additional feedback.

@jash-kothari
Copy link
Contributor Author

@seanmarcia Hi need your help in writing test cases for mailer.I dont have any idea about writing test cases for mailers.

@jash-kothari
Copy link
Contributor Author

jash-kothari commented Oct 16, 2018

  • In the PR description, include step-by-step instructions (including any necessary configuration steps) for how to verify your code changes and confirm behavior is good
  • Add a simple spec that runs through the happy path for how this feature might get used
  • Make sure rubocop is passing (run rubocop -a to see failures and recommendations for how to fix)

@seanmarcia seanmarcia merged commit 3fbc750 into master Oct 17, 2018
@seanmarcia seanmarcia deleted the 487 branch October 30, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirmation Email & Background Jobs
5 participants