6 dry up addresses used in our specs #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Had to change two .csv files to only have one example
armahillo
requested changes
Feb 24, 2019
spec/rails_helper.rb
Outdated
| # "789 Donation Site Way", | ||
| # "123 Location Way", | ||
| # "456 Location Way", | ||
| # "789 Location Way"].each do |address| |
There was a problem hiding this comment.
These can be deleted -- they will show up in the history
armahillo
approved these changes
Feb 25, 2019
|
@armahillo hey, is there anyway for you (or me even, but I think only you or another person on your end can do this) merge this into the repo under LoynoCS for diaper, I should've made the pull request there anyway, |
armahillo
added
Loyola
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1
Description
Type of change
The issue presented was to dry up number of test addresses within the spec files from 15 to one or two. I was successfully able to do this: there are now two test addresses and one test organization. One address is used with multiple tests, I had to change other test addresses to this one. The other test address was imported from a csv file into the test, in the original file, there were three addresses, I changed that to one and changed the test to only test to see if one was there. One test organization was needed for multiple tests, which is why I kept it.
How Has This Been Tested?
<! The issue was tested by running the entire rspec suite and then testing each error individually with
--next-failure, to replicate this, run rspec. As of now, the test suite runs with no errors
Screenshots
-->