Changes removed before push

Gemfile.lock

@@ -234,7 +234,7 @@ GEM
     mimemagic (0.3.2)
     mini_magick (4.9.2)
     mini_mime (1.0.1)
-    mini_portile2 (2.3.0)
+    mini_portile2 (2.4.0)
     minitest (5.11.3)
     momentjs-rails (2.20.1)
       railties (>= 3.1)
@@ -245,8 +245,8 @@ GEM
     net-ssh (5.0.2)
     newrelic_rpm (5.6.0.349)
     nio4r (2.3.1)
-    nokogiri (1.8.5)
-      mini_portile2 (~> 2.3.0)
+    nokogiri (1.10.1)
+      mini_portile2 (~> 2.4.0)
     notiffany (0.1.1)
       nenv (~> 0.1)
       shellany (~> 0.0)

app/jobs/update_diaper_partner_job.rb

@@ -5,7 +5,12 @@ class UpdateDiaperPartnerJob
 
   def perform(partner_id)
     @partner = Partner.find(partner_id)
-    DiaperPartnerClient.post(@partner.attributes) if Flipper.enabled?(:email_active)
-    @partner.update(status: "Pending")
+    @response = DiaperPartnerClient.post(@partner.attributes) if Flipper.enabled?(:email_active)
+
+    if @response&.value == Net::HTTPSuccess
+      @partner.update(status: "Pending")
+    else
+      @partner.update(status: "Error")
+    end
   end
 end

app/services/diaper_partner_client.rb

@@ -1,6 +1,6 @@
 module DiaperPartnerClient
   def self.post(attributes)
-    return if Rails.env != "production"
+    return if Rails.env != "production" # did ryan change this from development?
 
     partner = { partner:
       { diaper_bank_id: attributes["organization_id"],

db/schema.rb

@@ -222,7 +222,6 @@
     t.string "zipcode"
     t.float "latitude"
     t.float "longitude"
-    t.text "default_email_text"
     t.index ["latitude", "longitude"], name: "index_organizations_on_latitude_and_longitude"
     t.index ["short_name"], name: "index_organizations_on_short_name"
   end

spec/jobs/update_diaper_partner_job_spec.rb

@@ -1,13 +1,5 @@
 RSpec.describe UpdateDiaperPartnerJob, job: true do
   describe ".perform_async" do
-    it "updates partner status to Pending" do
-      partner = create(:partner)
-
-      UpdateDiaperPartnerJob.perform_async(partner.id)
-
-      expect(partner.reload.status).to eq("Pending")
-    end
-
     it "posts via DiaperPartnerClient" do
       partner = create(:partner)
       allow(Flipper).to receive(:enabled?) { true }
@@ -16,5 +8,39 @@
 
       UpdateDiaperPartnerJob.perform_async(partner.id)
     end
+
+    describe "Responses >" do
+      before do
+        allow(Flipper).to receive(:enabled?) { true }
+        @partner = create(:partner)
+      end
+      context "with a successful POST response" do
+        before do
+          response = double("Response", value: Net::HTTPSuccess)
+          allow(DiaperPartnerClient).to receive(:post).and_return(response)
+        end
+
+        it "sets the partner status to pending" do
+          expect do
+            UpdateDiaperPartnerJob.perform_async(@partner.id)
+            @partner.reload
+          end.to change { @partner.status }.to("Pending")
+        end
+      end
+
+      context "with a unsuccessful POST response" do
+        before do
+          response = double("Response", value: nil)
+          allow(DiaperPartnerClient).to receive(:post).and_return(response)
+        end
+
+        it "sets the partner status to error" do
+          expect do
+            UpdateDiaperPartnerJob.perform_async(@partner.id)
+            @partner.reload
+          end.to change { @partner.status }.to("Error")
+        end
+      end
+    end
   end
 end