Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the cancel button #813

Merged

Conversation

Skyg21
Copy link

@Skyg21 Skyg21 commented Apr 22, 2019

Checklist:

  • I have performed a self-review of my own code,
  • I have commented my code, particularly in hard-to-understand areas,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works,
  • New and existing unit tests pass locally with my changes ("bundle exec rake"),
  • Title include "WIP" if work is in progress.

Resolves Loyola#7 - Add in the ability to cancel requests

Description

Organizations have the ability to view and then fulfill requests. The completion of issue # 7 "Add in the ability to cancel requests", will allow the ability for organizations to cancel (destroy) a request as well as view, and fulfill. The "Cancel" button will delete the request, with a confirmation dialog, and an email notification will be sent to the Partner that has requested to cancel.

Include anything else we should know about. --> WIP

Type of change

  • New feature (non-breaking change which adds functionality)
    - The ability to Cancel Requests

How Has This Been Tested?

The changes can be found in the DiaperBase application under "Requests."

Screenshots

Include screenshots (before / after) for style changes, highlight edited element.-->
Screen Shot 2019-04-22 at 5 01 43 PM
Screen Shot 2019-04-22 at 5 04 08 PM

@Skyg21 Skyg21 changed the title Added the cancel button, function is still in progress Added the cancel button, function is WIP Apr 22, 2019
@armahillo
Copy link
Collaborator

@Skyg21 Is this feature ready for review? The PR still says it's a draft.

@armahillo armahillo added In Progress ❇️ Github First-timer This Pull Request is a user's first pull-request, EVER Loyola Issues tagged for contributors from Loyola University labels Apr 27, 2019
@armahillo armahillo marked this pull request as ready for review May 25, 2019 19:22
@armahillo
Copy link
Collaborator

I just looked over the diff in more detail -- it appears to be ready, pending CI approval.

Thank you, @Skyg21 !

@armahillo armahillo changed the title Added the cancel button, function is WIP Added the cancel button May 25, 2019
@armahillo
Copy link
Collaborator

Just merged conflicts, ran rubocop.

@armahillo armahillo changed the base branch from master to loyno-request-delete May 25, 2019 21:26
@armahillo armahillo merged commit b66692d into rubyforgood:loyno-request-delete May 25, 2019
@armahillo armahillo deleted the 7-cancel-request branch May 25, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❇️ Github First-timer This Pull Request is a user's first pull-request, EVER Loyola Issues tagged for contributors from Loyola University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants