Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Merge #6112
Browse files Browse the repository at this point in the history
6112: Add a spec for installing git deps after packaging without git r=deivid-rodriguez a=segiddins

### What was the end-user problem that led to this PR?

The problem was v1.15 seemed to break installing without git when the git deps had already been packaged (see #6066).

### What was your diagnosis of the problem?

My diagnosis was we actually seemed to have fixed this for 1.16.

### What is your fix for the problem, implemented in this PR?

My fix adds a test to ensure we won't regress.

Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
  • Loading branch information
bundlerbot and segiddins committed Aug 27, 2019
2 parents c808184 + 65351c5 commit 35781bb
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions spec/cache/git_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -220,5 +220,22 @@
gemspec = bundled_app("vendor/cache/foo-1.0-#{ref}/foo.gemspec").read
expect(gemspec).to_not match("`echo bob`")
end

it "can install after #{cmd} with git not installed" do
build_git "foo"

gemfile <<-G
gem "foo", :git => '#{lib_path("foo-1.0")}'
G
bundle! "config set cache_all true"
bundle! cmd, "all-platforms" => true, :install => false, :path => "./vendor/cache"

simulate_new_machine
with_path_as "" do
bundle! "config set deployment true"
bundle! :install, :local => true
expect(the_bundle).to include_gem "foo 1.0"
end
end
end
end

0 comments on commit 35781bb

Please sign in to comment.