Merge pull request #3312 from rubygems/fix-dependency-links

Fix dependency links pointing to its dependant
rubygems · Dec 26, 2022 · 9b69e2a · 9b69e2a
2 parents da345df + e94d591
commit 9b69e2a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/views/rubygems/_dependencies.html.erb b/app/views/rubygems/_dependencies.html.erb
@@ -5,7 +5,7 @@
       <% dependencies.each do |dependency| %>
         <% dependency.rubygem.tap do |rubygem| %>
           <div class="<%= class_names("gem__requirement-wrap", "gem__unregistered": !rubygem) %>">
-            <%= link_to_if rubygem, tag.strong(rubygem&.name || dependency.name), {}, class: "t-list__item" %>
+            <%= link_to_if rubygem, tag.strong(rubygem&.name || dependency.name), rubygem, class: "t-list__item" %>
             <%= dependency.clean_requirements %>
           </div>
         <% end %>

diff --git a/test/functional/rubygems_controller_test.rb b/test/functional/rubygems_controller_test.rb
@@ -298,6 +298,10 @@ class RubygemsControllerTest < ActionController::TestCase
       assert page.has_content?(@version.dependencies.runtime.count)
       assert page.has_content?(@version.dependencies.development.count)
     end
+    should "show proper links to dependencies" do
+      assert page.has_link?(@runtime.rubygem.name, href: "/gems/#{@runtime.rubygem.name}")
+      assert page.has_link?(@development.rubygem.name, href: "/gems/#{@development.rubygem.name}")
+    end
   end
 
   context "On GET to show for a gem with dependencies that are unresolved" do