Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace quiet_assets gem with sprockets-rails 3.1.0 config #1352

Merged
merged 1 commit into from
Jul 1, 2016

Conversation

kmcphillips
Copy link
Contributor

@kmcphillips kmcphillips commented Jun 28, 2016

@sonalkr132 @dwradcliffe

You can rebase #1341 over this to simplify it a bit. Part of the Rails 5 upgrade.

Replaces quiet_assets with config in sprockets-rails. Bumps the sprockets-rails version to 3.1.0 to include the feature. rails/sprockets-rails#355

@kmcphillips kmcphillips mentioned this pull request Jun 28, 2016
@dwradcliffe
Copy link
Member

👍

@dwradcliffe dwradcliffe merged commit 26cdf84 into rubygems:master Jul 1, 2016
@sonalkr132
Copy link
Member

This doesn't work in rails 4 😓

@kmcphillips
Copy link
Contributor Author

I should have waited for 4.2.7. There's a bug in ActiveSupport::Logger#silence that prevents this from also silencing the console (it silences the log file) that has been backported to 4-2-stable.

@kmcphillips
Copy link
Contributor Author

rails/rails#25341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants