Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add ruby.intellisense configuration option #259

Merged
merged 4 commits into from
Feb 9, 2018

Conversation

castwide
Copy link
Contributor

@castwide castwide commented Feb 4, 2018

This PR adds the ruby.intellisense configuration to allow method selection for go to/peek definition similar to ruby.codeCompletion. Valid options are solargraph, rubyLocate, and none.

@wingrunr21
Copy link
Collaborator

Should this PR also remove the extension dependency on solargraph?

@castwide
Copy link
Contributor Author

castwide commented Feb 6, 2018

The extension dependency is still necessary for the solargraph options to work. This PR helps ensure that only one intellisense provider is registered, so "go to definition" doesn't return duplicated entries.

@wingrunr21
Copy link
Collaborator

Gotcha. I guess my concern is if users select rubyLocate or none, they are going to wonder why the solargraph extension is a requirement if they are not using it.

@castwide
Copy link
Contributor Author

castwide commented Feb 6, 2018

Fair point. If neither ruby.codeCompletion nor ruby.intellisense is set to solargraph, the extension is not strictly required (although it will still provide access to documentation through the command palette). Making it a dependency is just the easiest way to integrate it.

@wingrunr21
Copy link
Collaborator

Ok. I'm going to open an issue on the topic (as I'm not convinced having it as a hard dependency is the right choice) but I also don't want to hold up this change. A standalone issue will allow other commentary and we can always remove the dependency later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants