This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Improve/Fix Block Parameter highlighting #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Master Branch shows this for Block Parameters lists:
Minor modifications to the grammar allow block parameters to be highlighted more consistently:
Added two new scopes:
variable.other.block.unused.ruby(to denote arguments that will go unused by the block, I've also kept thevariable.other.constant.rubythat was previously applied to these so the highlighting stays even in the interim;meta.block.parameters.rubyto flesh out the detail of the scope.Much of the matching for this was borrowed and modified off of the preexisting
meta.function.method.with-arguments.ruby>variable.parameter.function.rubyscopes.