Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 23.6.1 #65

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update to node 23.6.1 #65

merged 1 commit into from
Feb 4, 2025

Conversation

bnoordhuis
Copy link
Collaborator

Note that V8 12.9 requires a C++20-capable compiler.

@bnoordhuis
Copy link
Collaborator Author

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

🤦

@bnoordhuis
Copy link
Collaborator Author

CI failures are expected, mini_racer needs an update. I have that commit sitting ready in bnoordhuis/mini_racer@79c085c

@bnoordhuis
Copy link
Collaborator Author

Added a temp commit that clones the aforementioned commit from my local fork instead of rubyjs/mini_racer, to showcase that mini_racer indeed works with this new version of V8.

@bnoordhuis
Copy link
Collaborator Author

Interesting... there's a failing CI job in my local fork that passes upstream (i.e. here): https://github.com/bnoordhuis/libv8-node/actions/runs/13078473417/job/36505743137

The failure:

/usr/local/lib/ruby/3.1.0/mkmf.rb:490:in `try_do': The compiler failed to generate an executable file. (RuntimeError)
You have to install development tools first.

Which could be explained by the ruby:3.1 docker image. It's based on debian bullseye and comes with gcc 10, while node has gcc 12.2 as its minimum requirement.

But... then how come it works here? Weird.

Anyway, if you feel this is good to merge, let me know and I'll drop the commit that points to my mini_racer fork.

@bnoordhuis bnoordhuis merged commit ad3d897 into rubyjs:node-23 Feb 4, 2025
8 checks passed
@bnoordhuis bnoordhuis deleted the node-23 branch February 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant