Disable strict aliasing #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macos failures:
i.e., network outage. It's trying to build libv8-node from source, is that expected? musl failures:
Pre-existing, same build error on main. Started with commit 9ef1982, I think. |
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions) and, critically, disable strict aliasing, because V8 is not the least bit strict-aliasing safe. Upstream turned it off in nodejs/node#54339, like it always should have been, and I suspect the mismatch may be the cause of segfaults that show up in production.
bnoordhuis
force-pushed
the
fno-strict-aliasing
branch
from
fd8dba1 to
54673dd
Compare
|
musl error is most likely because of rubyjs/libv8-node#60 |
SamSaffron
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harmonize C++ compiler flags with Node.js (-fno-rtti, -fno-exceptions) and, critically, disable strict aliasing, because V8 is not the least bit strict-aliasing safe.
Upstream turned it off in nodejs/node#54339, like it always should have been, and I suspect the mismatch may be the cause of segfaults that show up in production.
Remove -fpermissive, it's not needed and something to discourage.