Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mixed prometheus_client and probe_metric approachs to use PrometheusPusher #129

Open
voetberg opened this issue Feb 12, 2024 · 0 comments
Open

Change mixed prometheus_client and probe_metric approachs to use PrometheusPusher #129

voetberg opened this issue Feb 12, 2024 · 0 comments
Assignees
@voetberg

Comments

@voetberg
Copy link
Contributor

Most probes in common use a combination of prometheus_client.CollectorRegistry/Gauge and probe_metrics, which is outdated now that PrometheusPusher exists and works.

The probes changed in pr #89 are also impacted, but so are all of the probes in common, if they use any context manager at all. It's easy enough to just update them all.
voetberg added a commit to voetberg/rucio_probes that referenced this issue Feb 15, 2024
@voetberg
Update to use Prometheus Pusher context manager, rucio#129
ef2d176
voetberg added a commit to voetberg/rucio_probes that referenced this issue Feb 15, 2024
@voetberg
Update to use Prometheus Pusher context manager, rucio#129
072758c
voetberg added a commit to voetberg/rucio_probes that referenced this issue Feb 20, 2024
@voetberg
Common: Replace string formatter with f-strings, format context messa…
06e62b9 
…ge uniformly rucio#129
voetberg added a commit to voetberg/rucio_probes that referenced this issue Feb 20, 2024
@voetberg
Common: Replace string formatter with f-strings, format context mess…
7992510 
…age uniformly rucio#129

            Changes to metric names include:
            * undertaker_expired_dids -> expired_dids.total
            * fts3.{hostname}.submitted -> fts_backlog.submitted.{hostname}
            * hermes_queues_messages.queues.messages -> messages_to_submit.queues.messages
            * transmogrifier_new_dids -> new_dids
            * judge_stuck_rules_without_missing_source_replica -> stuck_rules.{source_status} (source_status = [without_missing_source_replica, with_missing_source_replica])
            * check_transfer_queues_status -> transfer_queues_status
            * judge.waiting_dids -> unevaluated_dids
            * reaper.unlocked_replicas -> unlocked_replicas.{replica_status} (replica_status = [expired, unlocked])
            * judge.updated_dids -> updated_dids
voetberg added a commit to voetberg/rucio_probes that referenced this issue Feb 20, 2024
@voetberg
Common: Replace string formatter with f-strings, format context messa…
174bfd1 
…ge uniformly rucio#129

                Changes to metric names include:
                * undertaker_expired_dids -> expired_dids.total
                * fts3.{hostname}.submitted -> fts_backlog.submitted.{hostname}
                * hermes_queues_messages.queues.messages -> messages_to_submit.queues.messages
                * transmogrifier_new_dids -> new_dids
                * judge_stuck_rules_without_missing_source_replica -> stuck_rules.{source_status} (source_status = [without_missing_source_replica, with_missing_source_replica])
                * check_transfer_queues_status -> transfer_queues_status
                * judge.waiting_dids -> unevaluated_dids
                * reaper.unlocked_replicas -> unlocked_replicas.{replica_status} (replica_status = [expired, unlocked])
                * judge.updated_dids -> updated_dids
voetberg added a commit to voetberg/rucio_probes that referenced this issue Mar 1, 2024
@voetberg
Common: Replace string formatter with f-strings, format context messa…
4f8992e 
…ge uniformly rucio#129

Changes to metric names include:
                    * undertaker_expired_dids -> expired_dids.total
                    * fts3.{hostname}.submitted -> fts_backlog.submitted.{hostname}
                    * hermes_queues_messages.queues.messages -> messages_to_submit.queues.messages
                    * transmogrifier_new_dids -> new_dids
                    * judge_stuck_rules_without_missing_source_replica -> stuck_rules.{source_status} (source_status = [without_missing_source_replica, with_missing_source_replica])
                    * check_transfer_queues_status -> transfer_queues_status
                    * judge.waiting_dids -> unevaluated_dids
                    * reaper.unlocked_replicas -> unlocked_replicas.{replica_status} (replica_status = [expired, unlocked])
                    * judge.updated_dids -> updated_dids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voetberg voetberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@voetberg