test(monorepo): update MSW and othr dependencies to latest #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardisg
requested review from
ItsSudip,
shrouti1507,
sandeepdsvs,
koladilip,
mihir-4116,
saikumarrs and
MoumitaM
as code owners
WalkthroughThis update primarily focuses on enhancing testing environments and server response handling across various components of a JavaScript analytics framework. It introduces a shift from using REST to HTTP for better control over responses, streamlines polyfills, and extends the JSDOM environment for improved testing compatibility. Additionally, it revises the handling of JavaScript file loading and updates server mock setups, ensuring a more robust and efficient testing strategy. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
saikumarrs
approved these changes
Feb 27, 2024
|
@coderabbitai review |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (14)
package-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-common/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/analytics-js-integrations/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-plugins/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/package.jsonis excluded by:!**/*.jsonpackages/analytics-js-service-worker/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/analytics-js/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/package.jsonis excluded by:!**/*.jsonpackages/analytics-v1.1/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/loading-scripts/tsconfig.spec.jsonis excluded by:!**/*.jsonpackages/sanity-suite/__fixtures__/sourceConfig1.jsonis excluded by:!**/*.json
Files selected for processing (13)
- jest.preset.js (1 hunks)
- jest/jest.polyfills.js (2 hunks)
- jest/jsdom-extended.js (1 hunks)
- packages/analytics-js-common/fixtures/msw.handlers.ts (1 hunks)
- packages/analytics-js-common/tests/services/ExternalSrcLoader/ExternalSrcLoader.test.ts (6 hunks)
- packages/analytics-js-plugins/fixtures/msw.handlers.js (2 hunks)
- packages/analytics-js-service-worker/fixtures/msw.server.ts (1 hunks)
- packages/analytics-js-service-worker/tests/Analytics.test.ts (3 hunks)
- packages/analytics-js/fixtures/msw.handlers.ts (1 hunks)
- packages/analytics-js/tests/components/configManager/ConfigManager.test.ts (2 hunks)
- packages/analytics-v1.1/fixtures/msw.handlers.js (2 hunks)
- packages/analytics-v1.1/tests/transformationHandler.test.js (5 hunks)
- patches/nx+18.0.5.patch (2 hunks)
Files skipped from review due to trivial changes (1)
- jest/jest.polyfills.js
Additional comments: 19
packages/analytics-js-service-worker/__fixtures__/msw.server.ts (2)
- 1-3: The import statements for
setupServerfrommsw/node, andhttp,HttpResponsefrommsware correctly updated to reflect the new usage patterns introduced by the MSW library update. This aligns with the PR's objective to update dependencies and improve HTTP request handling in tests.- 5-11: The setup of the MSW server using
http.postto handle POST requests to${dummyDataplaneHost}/v1/batchwith a 200 status response is correctly implemented. This change from the previousresthandlers tohttphandlers is in line with the MSW update and enhances the control over server responses. The use ofHttpResponseto specify the response status is appropriate and follows best practices for testing HTTP interactions.jest/jsdom-extended.js (1)
- 1-26: The extension of
JSDOMEnvironmentto include polyfills forReadableStream,TextDecoder,TextEncoder,Blob,File,Headers,FormData,Request,Response, andfetchis correctly implemented. This ensures compatibility with MSW v2 by providing the necessary global objects that might be used by MSW or tests. The inclusion ofstructuredCloneis also a good practice, as it's a modern API for deep cloning objects. This setup is essential for tests that rely on these APIs being available in the JSDOM environment.packages/analytics-js-plugins/__fixtures__/msw.handlers.js (2)
- 1-1: The import statement correctly updates to use
httpandHttpResponsefrommsw, aligning with the PR's objective to leverage the latest MSW functionalities for handling HTTP requests in a more controlled manner.- 10-41: The update to use
http.postfor defining request handlers and the use ofHttpResponsefor specifying responses is correctly implemented across various scenarios (success,partialSuccess,invalidResponse,badRequest,accessDenied,serverDown). This change enhances the flexibility and control over the mock server's responses, allowing for more detailed specification of response content and headers. It's also consistent with the PR's goal of updating to the latest MSW version and improving HTTP request handling in tests.packages/analytics-v1.1/__fixtures__/msw.handlers.js (2)
- 1-1: The import statement correctly updates to use
httpandHttpResponsefrommsw, aligning with the PR's objective to leverage the latest MSW functionalities for handling HTTP requests in a more controlled manner.- 10-47: The update to use
http.postfor defining request handlers and the use ofHttpResponsefor specifying responses is correctly implemented across various scenarios (success,partialSuccess,invalidResponse,badRequest,accessDenied,serverDown). This change enhances the flexibility and control over the mock server's responses, allowing for more detailed specification of response content and headers. It's also consistent with the PR's goal of updating to the latest MSW version and improving HTTP request handling in tests.packages/analytics-js-common/__tests__/services/ExternalSrcLoader/ExternalSrcLoader.test.ts (10)
- 42-42: Appending
.jsto the URL ensures that scripts are loaded correctly with the updated file extensions. This change is consistent with the PR's objectives and appears to be correctly applied here.- 47-47: The URL for loading the JavaScript file correctly includes the
.jsextension, aligning with the changes made elsewhere in this file. This consistency is crucial for the correct loading of scripts.- 81-81: Again, the
.jsextension is correctly appended to the URL, ensuring consistency across the test cases. This change is necessary for the correct loading of scripts with the updated file extensions.- 93-96: The creation of a script element with a URL that includes the
.jsextension is consistent with the PR's objectives. This ensures that the script is loaded correctly with the updated file extensions.- 100-100: The assertion checks the script's
srcattribute for the correct URL, including the.jsextension. This is a good practice to ensure that the script is loaded as expected.- 110-113: Creating a script element with the
.jsextension in the URL is consistent with the changes made throughout this file. This consistency is important for the correct loading of scripts.- 116-116: Inserting a script with the
.jsextension in the URL ensures that the script is loaded correctly. This change aligns with the PR's objectives and is applied consistently.- 129-129: The script element's
srcattribute correctly includes the.jsextension, ensuring that the script is loaded as expected. This consistency with the PR's objectives is crucial.- 154-154: The assertion checks for the correct
srcattribute, including the.jsextension. This ensures that the script is loaded correctly, aligning with the PR's objectives.- 161-161: Loading a JavaScript file with the URL correctly including the
.jsextension is consistent with the changes made elsewhere in this file. This consistency is crucial for the correct loading of scripts.packages/analytics-js/__tests__/components/configManager/ConfigManager.test.ts (2)
- 2-2: The import of
httpandHttpResponsefrommswis correctly added to replace the previousrestusage. This change aligns with the PR's objectives to enhance HTTP request handling in tests.- 139-146: The replacement of
restwithhttpfor making a GET request and the use ofHttpResponsefor specifying the response is correctly implemented. This change enhances the control over server responses by allowing for more detailed specification of response content and headers, aligning with the PR's objectives.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1629 +/- ##
===========================================
- Coverage 54.70% 52.32% -2.39%
===========================================
Files 581 581
Lines 17740 16592 -1148
Branches 3236 3239 +3
===========================================
- Hits 9704 8681 -1023
+ Misses 6623 6436 -187
- Partials 1413 1475 +62 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
update MSW and othr dependencies to latest
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit