Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(non CFD): Matomo customDimensions error #558

Merged
merged 3 commits into from
Jul 12, 2022
Merged

bugfix(non CFD): Matomo customDimensions error #558

merged 3 commits into from
Jul 12, 2022

Conversation

rohithkaza
Copy link
Contributor

@rohithkaza rohithkaza commented Jul 12, 2022 •
edited
Loading

Description of the change

Here, we are using forEach for customDimensionsMap(an object), which throws an error.
To fix this we are using each instead of forEach

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@rohithkaza rohithkaza added Ready for review Changes are ready to be reviewed bug fix labels Jul 12, 2022
@rohithkaza rohithkaza requested a review from ItsSudip July 12, 2022 04:51
@rohithkaza rohithkaza self-assigned this Jul 12, 2022
utsabc
utsabc reviewed Jul 12, 2022
View reviewed changes
integrations/Matomo/util.js Outdated Show resolved Hide resolved
@utsabc utsabc merged commit bef68b1 into v1-staging Jul 12, 2022
@utsabc utsabc deleted the bugfix/matomo branch July 12, 2022 08:00
@rohithkaza rohithkaza removed the Ready for review Changes are ready to be reviewed label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsSudip ItsSudip ItsSudip approved these changes

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@rohithkaza rohithkaza

Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohithkaza @utsabc @ItsSudip