Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Packages cleanup #566

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Jul 13, 2022

Description of the change

  • Removed unwanted packages and added missing dependency.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs self-assigned this Jul 13, 2022
@saikumarrs saikumarrs requested a review from MoumitaM as a code owner July 13, 2022 17:14
@github-actions
Copy link

github-actions bot commented Jul 13, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 36.56 KB (0%) 732 ms (0%) 141 ms (-1.14% 🔽) 872 ms
All Integrations - CDN 663.44 KB (0%) 13.3 s (0%) 984 ms (-16% 🔽) 14.3 s
Core - NPM 36.73 KB (0%) 735 ms (0%) 184 ms (+39.48% 🔺) 919 ms

MoumitaM
MoumitaM previously approved these changes Jul 14, 2022
@saikumarrs saikumarrs merged commit e0616bf into production-staging Jul 14, 2022
@saikumarrs saikumarrs deleted the patch/package-cleanup branch July 14, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants