Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix[SnapPixel]: update init, identify and track call #571

Merged
merged 4 commits into from
Jul 21, 2022
Merged

bugfix[SnapPixel]: update init, identify and track call #571

merged 4 commits into from
Jul 21, 2022

Conversation

sauravlal-rudderstack
Copy link
Contributor

@sauravlal-rudderstack sauravlal-rudderstack commented Jul 18, 2022 •
edited by SumanthPuram
Loading

Description of the change

Update init, Identify and Track function, also added option of client_deduplication_id to take from key mentioned by the user or from messageId.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@sauravlal-rudderstack sauravlal-rudderstack added Ready for review Changes are ready to be reviewed bug fix labels Jul 18, 2022
@sauravlal-rudderstack sauravlal-rudderstack self-assigned this Jul 18, 2022
@sauravlal-rudderstack sauravlal-rudderstack changed the title bugfix[SnapPixel]: update identify and track call bugfix[SnapPixel]: update init, identify and track call Jul 18, 2022
ItsSudip
ItsSudip reviewed Jul 19, 2022
View reviewed changes
integrations/SnapPixel/browser.js Outdated Show resolved Hide resolved
integrations/SnapPixel/util.js Outdated Show resolved Hide resolved
ItsSudip
ItsSudip previously approved these changes Jul 20, 2022
View reviewed changes
@sauravlal-rudderstack sauravlal-rudderstack merged commit 7731e33 into v1-staging Jul 21, 2022
@sauravlal-rudderstack sauravlal-rudderstack deleted the bugfix/Snapchat-pixel branch July 21, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@akashrpo akashrpo akashrpo approved these changes

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@sauravlal-rudderstack sauravlal-rudderstack

Labels
bug fix Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sauravlal-rudderstack @utsabc @akashrpo @ItsSudip