Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LaunchDarkly anonymous users shared key #575

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

chandlervdw
Copy link
Member

Support LaunchDarkly key override

This supports options.integrations.LaunchDarkly.key as an override of the key field sent to the LaunchDarkly JS API. This allows for anonymous users to have a shared key so that the autogenerated Rudderstack ID for anonymous users is not sent to LaunchDarkly, and therefore all anonymous users share the same key. This is an additive change.
LaunchDarkly JS SDK key API

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fix #569
This originated with #570 but that was branched off of develop. This branches from v1-staging.

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@chandlervdw chandlervdw self-assigned this Jul 22, 2022
@chandlervdw chandlervdw added Ready for review Changes are ready to be reviewed bug fix labels Jul 22, 2022
@saikumarrs saikumarrs merged commit a79efea into v1-staging Jul 22, 2022
@saikumarrs saikumarrs deleted the launchdarkly-anonymousUsersSharedKey branch July 22, 2022 14:11
@chandlervdw chandlervdw mentioned this pull request Aug 1, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants