fix: loopvar issue

rudderlabs · Sep 25, 2023 · b80e5e1 · b80e5e1
1 parent 68792e6
commit b80e5e1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/backend-config/replay_types_test.go b/backend-config/replay_types_test.go
@@ -20,7 +20,12 @@ func TestApplyReplayConfig(t *testing.T) {
 					},
 					Destinations: []DestinationT{
 						{
-							ID: "d-1",
+							ID:                 "d-1",
+							IsProcessorEnabled: true,
+						},
+						{
+							ID:                 "d-2",
+							IsProcessorEnabled: false,
 						},
 					},
 				},
@@ -56,6 +61,7 @@ func TestApplyReplayConfig(t *testing.T) {
 		require.Equal(t, map[string]interface{}{}, c.Sources[1].Config)
 		require.Len(t, c.Sources[1].Destinations, 1)
 		require.Equal(t, "er-d-1", c.Sources[1].Destinations[0].ID)
+		require.True(t, c.Sources[1].Destinations[0].IsProcessorEnabled)
 	})
 
 	t.Run("Invalid Replay Config", func(t *testing.T) {

diff --git a/backend-config/types.go b/backend-config/types.go
@@ -104,16 +104,19 @@ type ConfigT struct {
 
 func (c *ConfigT) SourcesMap() map[string]*SourceT {
 	sourcesMap := make(map[string]*SourceT)
-	for _, source := range c.Sources {
+	for i := range c.Sources {
+		source := c.Sources[i]
 		sourcesMap[source.ID] = &source
 	}
 	return sourcesMap
 }
 
 func (c *ConfigT) DestinationsMap() map[string]*DestinationT {
 	destinationsMap := make(map[string]*DestinationT)
-	for _, source := range c.Sources {
-		for _, destination := range source.Destinations {
+	for i := range c.Sources {
+		source := c.Sources[i]
+		for j := range source.Destinations {
+			destination := source.Destinations[j]
 			destinationsMap[destination.ID] = &destination
 		}
 	}