chore: add rsources stats for dropped events at processor #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
reviewed
Sep 13, 2023
processor/processor.go
Outdated
| @@ -2216,7 +2216,8 @@ func (proc *Handle) transformSrcDest( | |||
| var successCountMetadataMap map[string]MetricMetadata | |||
| eventsToTransform, successMetrics, successCountMap, successCountMetadataMap = proc.getDestTransformerEvents(response, commonMetaData, eventsByMessageID, destination, transformer.UserTransformerStage, trackingPlanEnabled, transformationEnabled) | |||
| failedJobs, failedMetrics, failedCountMap := proc.getFailedEventJobs(response, commonMetaData, eventsByMessageID, transformer.UserTransformerStage, transformationEnabled, trackingPlanEnabled) | |||
| proc.saveFailedJobs(failedJobs) | |||
| droppedJobs := proc.getDroppedJobs(response, eventList) | |||
| proc.saveFailedJobs(append(failedJobs, droppedJobs...)) | |||
There was a problem hiding this comment.
I believe that for rudder sources' use cases both failed and dropped jobs in processor's pipeline could be considered as dropped (i.e. non-retryable)
- We could rename
proc.saveFailedJobstoproc.saveDroppedJobsrsources.NewFailedJobsCollectortorsources.NewDroppedJobsCollectorrsources.JobsFailedtorsources.JobsDropped
- Dropped jobs failed keys shouldn't be captured
- It would be better to report rsources dropped jobs during
Store, once for all scenarios as the last operation of the method, after storing router, batchrouter & proc_errors
atzoum
reviewed
Sep 13, 2023
| func (proc *Handle) getDroppedJobs(response transformer.Response, eventsToTransform []transformer.TransformerEvent) []*jobsdb.JobT { | ||
| // each messageID is one event when sending to the transformer | ||
| inputMessageIDs := lo.Map(eventsToTransform, func(e transformer.TransformerEvent, _ int) string { | ||
| return e.Metadata.MessageID |
There was a problem hiding this comment.
I am confused why processor's pipeline operates on the assumption that messageIDs are unique. Dedup is a feature that can be turned off, right? Am I missing some other important fact with respect to message ids and the processor's pipeline?
There was a problem hiding this comment.
Yeah that is correct but dedup ideally should never be turned off
Also for many of the downstream destinations like Warehouse they do operate under the assumption that the primary key is the messageID which is unique
Sidddddarth
force-pushed
the
chore.rsourcesStatsForDroppedEvents
branch
2 times, most recently
from
20511d7 to
6c16717
Compare
Sidddddarth
force-pushed
the
chore.rsourcesStatsForDroppedEvents
branch
from
9eadca3 to
0dbe30f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3852 +/- ##
==========================================
- Coverage 69.07% 69.00% -0.08%
==========================================
Files 351 352 +1
Lines 52814 52858 +44
==========================================
- Hits 36480 36473 -7
- Misses 14043 14087 +44
- Partials 2291 2298 +7
☔ View full report in Codecov by Sentry. |
Sidddddarth
force-pushed
the
chore.rsourcesStatsForDroppedEvents
branch
2 times, most recently
from
6514b03 to
dbbd0f7
Compare
atzoum
reviewed
Sep 18, 2023
atzoum
reviewed
Sep 18, 2023
atzoum
approved these changes
Sep 19, 2023
atzoum
requested review from
lvrach,
fracasula,
cisse21,
BonapartePC,
achettyiitr and
pChondros
Sidddddarth
force-pushed
the
chore.rsourcesStatsForDroppedEvents
branch
from
6adcb4f to
a544978
Compare
1 task
cisse21
approved these changes
Sep 21, 2023
1 task
Closed
This was referenced Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linear Ticket
Ensure drop events are marked as failed in source [job-status endpoint]
Security