fix: rsources dropped jobs at processor #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
requested review from
atzoum,
cisse21,
lvrach,
BonapartePC,
fracasula,
achettyiitr and
pChondros
atzoum
reviewed
Sep 22, 2023
| failedJobs, failedMetrics, failedCountMap := proc.getFailedEventJobs(response, commonMetaData, eventsByMessageID, transformer.EventFilterStage, transformationEnabled, trackingPlanEnabled) | ||
| droppedJobs = append(droppedJobs, append(proc.getDroppedJobs(response, eventsToTransform), failedJobs...)...) | ||
| eventsToTransform, successMetrics, successCountMap, successCountMetadataMap = proc.getDestTransformerEvents(response, commonMetaData, eventsByMessageID, destination, transformer.EventFilterStage, trackingPlanEnabled, transformationEnabled) |
There was a problem hiding this comment.
Was that change in order purposeful?
There was a problem hiding this comment.
yeah.
eventsToTransform is modified after a call to proc.getDestTransformerEvents(...).
proc. getDroppedJobs needs the total list of events sent to transformer/event filter.
atzoum
reviewed
Sep 22, 2023
| @@ -2354,6 +2355,7 @@ func (proc *Handle) transformSrcDest( | |||
| errorsPerDestID: procErrorJobsByDestID, | |||
| reportMetrics: reportMetrics, | |||
| routerDestIDs: routerDestIDs, | |||
| droppedJobs: droppedJobs, | |||
There was a problem hiding this comment.
didn't we have a test for dropped jobs?
There was a problem hiding this comment.
missed this one😓
will post some more test cases soon.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
==========================================
- Coverage 69.16% 69.15% -0.02%
==========================================
Files 353 353
Lines 52903 52905 +2
==========================================
- Hits 36589 36584 -5
- Misses 13998 14001 +3
- Partials 2316 2320 +4
☔ View full report in Codecov by Sentry. |
atzoum
approved these changes
Sep 22, 2023
Sidddddarth
force-pushed
the
fix.rsourcesProcessorDroppedJobs
branch
from
17e1e58 to
cc07e71
Compare
cisse21
approved these changes
Sep 25, 2023
This was referenced Oct 9, 2023
Closed
This was referenced Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix for recent r-sources dropped jobs PR
Linear Ticket
Ensure drop events are marked as failed in source [job-status endpoint]
Security