Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replay request fails with 400 - request neither has anonymousId nor userId #3911

Merged
merged 3 commits into from
Sep 26, 2023

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Sep 25, 2023

Description

  • Treating replay request types equally to batch request types in terms of expected payload
  • Fixing a loopvar issue
  • Setting IsProcessorEnabled always true for replay destinations

Linear Ticket

PIPE-351

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the fix.replayBatchPayload branch from 70fb00f to b80e5e1 Compare September 25, 2023 20:50
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (741fd74) 69.14% compared to head (007b00f) 69.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3911      +/-   ##
==========================================
+ Coverage   69.14%   69.17%   +0.02%     
==========================================
  Files         353      353              
  Lines       52900    52904       +4     
==========================================
+ Hits        36580    36597      +17     
+ Misses      13999    13990       -9     
+ Partials     2321     2317       -4     
Files Coverage Δ
backend-config/replay_types.go 100.00% <100.00%> (ø)
backend-config/types.go 88.88% <100.00%> (+0.79%) ⬆️
gateway/handle.go 87.89% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants