Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using error from router http client #2628

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

chandumlg
Copy link
Member

Description

Properly using the error returned by router http client.

Notion Ticket

https://www.notion.so/rudderstacks/8aac9087df644365acdf64e28e290153?v=6e06b0a5ade24f0aa5ffe05dc2972e84&p=41cdfc6b98034dbfb0dd1f527c1db239&pm=s

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 44.09% // Head: 43.16% // Decreases project coverage by -0.92% ⚠️

Coverage data is based on head (b47c3f6) compared to base (b6ce9b9).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2628      +/-   ##
==========================================
- Coverage   44.09%   43.16%   -0.93%     
==========================================
  Files         187      186       -1     
  Lines       39255    40012     +757     
==========================================
- Hits        17308    17271      -37     
- Misses      20843    21639     +796     
+ Partials     1104     1102       -2     
Impacted Files Coverage Δ
router/network.go 52.29% <50.00%> (+2.29%) ⬆️
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
processor/processor.go 71.23% <0.00%> (-0.83%) ⬇️
services/rsources/handler.go 70.55% <0.00%> (-0.56%) ⬇️
router/batchrouter/batchrouter.go 33.87% <0.00%> (-0.27%) ⬇️
warehouse/upload.go 18.39% <0.00%> (-0.16%) ⬇️
warehouse/mssql/mssql.go 0.00% <0.00%> (ø)
warehouse/utils/utils.go 70.18% <0.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants