refactor: safe database initialisation and schema migration during startup #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 46.63% // Head: 46.79% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2734 +/- ##
==========================================
+ Coverage 46.63% 46.79% +0.15%
==========================================
Files 297 297
Lines 48696 48830 +134
==========================================
+ Hits 22711 22850 +139
+ Misses 24557 24527 -30
- Partials 1428 1453 +25
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
refactor.safeStartup
branch
2 times, most recently
from
3b7a7d6 to
1b81a06
Compare
atzoum
force-pushed
the
refactor.safeStartup
branch
2 times, most recently
from
6bacfbc to
b473414
Compare
pChondros
approved these changes
Nov 24, 2022
atzoum
force-pushed
the
refactor.safeStartup
branch
from
b473414 to
2d32146
Compare
fracasula
approved these changes
Nov 25, 2022
| App app.App | ||
| VersionHandler func(w http.ResponseWriter, r *http.Request) | ||
| // embeddedApp is the type for embedded type implementation | ||
| type embeddedApp struct { |
There was a problem hiding this comment.
Nice job with unexporting these types 👍
chandumlg
approved these changes
Nov 25, 2022
1 task
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running in
embeddedmode (core & warehouse) and using separate database instances for core & warehouse data, it is possible that one database's unavailability panic may cause the other database's schema migration to become dirty (corrupted) due to the asynchronous nature of the two components' startup sequence.To eliminate this, we are now initialising both databases sequentially and stop the process gracefully in case of an error. Database initialisation for reach component happens only if the component needs to be started.
Other improvements:
apphandlerspackage to remove global variablesrunner&apphandlerscenariosNotion Ticket
Link
Security